move everything not explicitly riot (or status) branded into matrix-react-sdk #6500

ara4n · 2018-04-11T22:56:48Z

This moves almost everything not explicitly riot (or status) branded into matrix-react-sdk, in order to fix the layering of riot-web v. matrix-react-sdk, as per https://docs.google.com/document/d/1itOIy6zdKGJCQZEPecL9uTPTtBCVrZ_HgwQiDnah_LM.

For now we're deliberately keeping the vector/ directory (i.e. the top level app skin itself) in the riot-web repo. In future we might want to provide a simple sample skin app in matrix-react-sdk.

Status:

this moves the files into the right(?) place
actually make it build again.
fix the tests
remerge the i18n

Whilst this PR is in flight, I suggest folks try to avoid making changes to the riot-web repository.

Twinned with matrix-org/matrix-react-sdk#1836

…eact-sdk

martindale · 2018-04-13T13:54:13Z

Recommend: prefix in-flight PRs with WIP: in their title. This looks awesome, otherwise!

…ct-sdk

ara4n · 2018-04-16T00:20:33Z

Right, I think this is good to go now.

@martindale yup - mea culpa on missing the WIP, although events have now overtaken that :)

lukebarnard1

Just minor things, otherwise looks good.

lukebarnard1 · 2018-04-17T09:30:23Z

test/unit-tests/README.md

@@ -0,0 +1,2 @@
+Any UTs for vector-web layer components or functionality should go here.
+This used to contain the UTs for notifications before they got moved to react-sdk.


Commit message is misleading here. Should there be changes to the tests as part of this commit?

sorry, this was a terrible commit message. the thing that was breaking the tests is that the unit-tests dir had winked out of existence. creating this README file recreated the directory and fixed the tests O:-)

lukebarnard1 · 2018-04-17T09:38:55Z

src/components/structures/VectorHomePage.js

-    displayName: 'HomePage',
+    displayName: 'VectorHomePage',
+    statics: {
+        replaces: 'HomePage',


This looks like it needs a comment.

i forgot about this. I need to turn HomePage into a ES6 class and then have VectorHomePage inherit from it (whilst also replaceing it)

dbkr · 2018-04-18T09:59:35Z

src/components/structures/VectorHomePage.js

-        };
-    },
+class VectorHomePage extends HomePage {
+    displayName = 'VectorHomePage'


Should this have a 'static' too? Also I think these want semicolons.

dbkr · 2018-04-18T10:06:11Z

src/vector/index.js

+require('matrix-react-sdk/node_modules/gemini-scrollbar/gemini-scrollbar.css');
+require('matrix-react-sdk/node_modules/gfm.css/gfm.css');
+require('matrix-react-sdk/node_modules/highlight.js/styles/github.css');
+require('matrix-react-sdk/node_modules/draft-js/dist/Draft.css');


I assume this didn't work without hardcoding the path? I think this might break between versions of npm.

yup, doesn't work if you try matrix-react-sdk/library-name/whatever.css. we have the same problem when doing SCSS imports of CSS from react-sdk into the vector layer. Any idea how we can make it non-npm-specific?

oh yep, I thought I'd seen that somewhere else. I don't know off hand any other way to do this, I guess other than importing the dependency directly.

* Show how long a call was on call tiles ([\element-hq#6570](matrix-org/matrix-react-sdk#6570)). Fixes element-hq#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add regional indicators to emoji picker ([\element-hq#6490](matrix-org/matrix-react-sdk#6490)). Fixes element-hq#14963. Contributed by [robintown](https://github.com/robintown). * Make call control buttons accessible to screen reader users ([\element-hq#6181](matrix-org/matrix-react-sdk#6181)). Fixes element-hq#18358. Contributed by [pvagner](https://github.com/pvagner). * Skip sending a thumbnail if it is not a sufficient saving over the original ([\element-hq#6559](matrix-org/matrix-react-sdk#6559)). Fixes element-hq#17906. * Increase PiP snapping speed ([\element-hq#6539](matrix-org/matrix-react-sdk#6539)). Fixes element-hq#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve and move the incoming call toast ([\element-hq#6470](matrix-org/matrix-react-sdk#6470)). Fixes element-hq#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Allow all of the URL schemes that Firefox allows ([\element-hq#6457](matrix-org/matrix-react-sdk#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist). * Improve bubble layout colors ([\element-hq#6452](matrix-org/matrix-react-sdk#6452)). Fixes element-hq#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Spaces let users switch between Home and All Rooms behaviours ([\element-hq#6497](matrix-org/matrix-react-sdk#6497)). Fixes element-hq#18093. * Support for MSC2285 (hidden read receipts) ([\element-hq#6390](matrix-org/matrix-react-sdk#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Group pinned message events with MELS ([\element-hq#6349](matrix-org/matrix-react-sdk#6349)). Fixes element-hq#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Make version copiable ([\element-hq#6227](matrix-org/matrix-react-sdk#6227)). Fixes element-hq#17603 and element-hq#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve voice messages uploading state ([\element-hq#6530](matrix-org/matrix-react-sdk#6530)). Fixes element-hq#18226 and element-hq#18224. * Add surround with feature ([\element-hq#5510](matrix-org/matrix-react-sdk#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve call event tile wording ([\element-hq#6545](matrix-org/matrix-react-sdk#6545)). Fixes element-hq#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Show an avatar/a turned off microphone icon for muted users ([\element-hq#6486](matrix-org/matrix-react-sdk#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Prompt user to leave rooms/subspaces in a space when leaving space ([\element-hq#6424](matrix-org/matrix-react-sdk#6424)). Fixes element-hq#18071. * none ([\element-hq#6455](matrix-org/matrix-react-sdk#6455)). Fixes element-hq#18035. * Add support for screen sharing in 1:1 calls ([\element-hq#5992](matrix-org/matrix-react-sdk#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Dismiss electron download toast when clicking Open ([\element-hq#18267](element-hq#18267)). Fixes element-hq#18266. * Fix [object Object] in Widget Permissions ([\element-hq#6560](matrix-org/matrix-react-sdk#6560)). Fixes element-hq#18384. Contributed by [Palid](https://github.com/Palid). * Fix right margin for events on IRC layout ([\element-hq#6542](matrix-org/matrix-react-sdk#6542)). Fixes element-hq#18354. * Mirror only usermedia feeds ([\element-hq#6512](matrix-org/matrix-react-sdk#6512)). Fixes element-hq#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix LogoutDialog warning + TypeScript migration ([\element-hq#6533](matrix-org/matrix-react-sdk#6533)). * Fix the wrong font being used in the room topic field ([\element-hq#6527](matrix-org/matrix-react-sdk#6527)). Fixes element-hq#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix inconsistent styling for links on hover ([\element-hq#6513](matrix-org/matrix-react-sdk#6513)). Contributed by [janogarcia](https://github.com/janogarcia). * Fix incorrect height for encoded placeholder images ([\element-hq#6514](matrix-org/matrix-react-sdk#6514)). Contributed by [Palid](https://github.com/Palid). * Fix call events layout for message bubble ([\element-hq#6465](matrix-org/matrix-react-sdk#6465)). Fixes element-hq#18144. * Improve subspaces and some utilities around room/space creation ([\element-hq#6458](matrix-org/matrix-react-sdk#6458)). Fixes element-hq#18090 element-hq#18091 and element-hq#17256. * Restore pointer cursor for SenderProfile in message bubbles ([\element-hq#6501](matrix-org/matrix-react-sdk#6501)). Fixes element-hq#18249. * Fix issues with the Call View ([\element-hq#6472](matrix-org/matrix-react-sdk#6472)). Fixes element-hq#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Align event list summary read receipts when using message bubbles ([\element-hq#6500](matrix-org/matrix-react-sdk#6500)). Fixes element-hq#18143. * Better positioning for unbubbled events in timeline ([\element-hq#6477](matrix-org/matrix-react-sdk#6477)). Fixes element-hq#18132. * Realign reactions row with messages in modern layout ([\element-hq#6491](matrix-org/matrix-react-sdk#6491)). Fixes element-hq#18118. Contributed by [robintown](https://github.com/robintown). * Fix CreateRoomDialog exploding when making public room outside of a space ([\element-hq#6492](matrix-org/matrix-react-sdk#6492)). Fixes element-hq#18275. * Fix call crashing because `element` was undefined ([\element-hq#6488](matrix-org/matrix-react-sdk#6488)). Fixes element-hq#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Upscale thumbnails to the container size ([\element-hq#6589](matrix-org/matrix-react-sdk#6589)). Fixes element-hq#18307. * Fix create room dialog in spaces no longer adding to the space ([\element-hq#6587](matrix-org/matrix-react-sdk#6587)). Fixes element-hq#18465. * Don't show a modal on call reject/user hangup ([\element-hq#6580](matrix-org/matrix-react-sdk#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fade Call View Buttons after `componentDidMount` ([\element-hq#6581](matrix-org/matrix-react-sdk#6581)). Fixes element-hq#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix missing expand button on codeblocks ([\element-hq#6565](matrix-org/matrix-react-sdk#6565)). Fixes element-hq#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * allow customizing the bubble layout colors ([\element-hq#6568](matrix-org/matrix-react-sdk#6568)). Fixes element-hq#18408. Contributed by [benneti](https://github.com/benneti). * Don't flash "Missed call" when accepting a call ([\element-hq#6567](matrix-org/matrix-react-sdk#6567)). Fixes element-hq#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix clicking whitespaces on replies ([\element-hq#6571](matrix-org/matrix-react-sdk#6571)). Fixes element-hq#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix composer not being disabled when sending voice messages ([\element-hq#6562](matrix-org/matrix-react-sdk#6562)). Fixes element-hq#18413. * none ([\element-hq#6550](matrix-org/matrix-react-sdk#6550)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix sizing issues of the screen picker ([\element-hq#6498](matrix-org/matrix-react-sdk#6498)). Fixes element-hq#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Stop voice messages that are playing when starting a recording ([\element-hq#6563](matrix-org/matrix-react-sdk#6563)). Fixes element-hq#18410. * Fix random box appearing when clicking room list headers. ([\element-hq#6561](matrix-org/matrix-react-sdk#6561)). Fixes element-hq#18414. * Null guard space inviter to prevent the app exploding ([\element-hq#6558](matrix-org/matrix-react-sdk#6558)). * Make the ringing sound mutable/disablable ([\element-hq#6534](matrix-org/matrix-react-sdk#6534)). Fixes element-hq#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix wrong cursor being used in PiP ([\element-hq#6551](matrix-org/matrix-react-sdk#6551)). Fixes element-hq#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Re-pin Jitsi if the widget already exists ([\element-hq#6226](matrix-org/matrix-react-sdk#6226)). Fixes element-hq#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix broken call notification regression ([\element-hq#6526](matrix-org/matrix-react-sdk#6526)). Fixes element-hq#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * createRoom, only send join rule event if we have a join rule to put in it ([\element-hq#6516](matrix-org/matrix-react-sdk#6516)). Fixes element-hq#18301. * Fix clicking pills inside replies ([\element-hq#6508](matrix-org/matrix-react-sdk#6508)). Fixes element-hq#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix grecaptcha regression ([\element-hq#6503](matrix-org/matrix-react-sdk#6503)). Fixes element-hq#18284. Contributed by [Palid](https://github.com/Palid). * Fix compatibility with accounts where the security passphrase was created on a mobile device ([\element-hq#1819](matrix-org/matrix-js-sdk#1819)).

* Show how long a call was on call tiles ([\element-hq#6570](matrix-org/matrix-react-sdk#6570)). Fixes element-hq#18405. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add regional indicators to emoji picker ([\element-hq#6490](matrix-org/matrix-react-sdk#6490)). Fixes element-hq#14963. Contributed by [robintown](https://github.com/robintown). * Make call control buttons accessible to screen reader users ([\element-hq#6181](matrix-org/matrix-react-sdk#6181)). Fixes element-hq#18358. Contributed by [pvagner](https://github.com/pvagner). * Skip sending a thumbnail if it is not a sufficient saving over the original ([\element-hq#6559](matrix-org/matrix-react-sdk#6559)). Fixes element-hq#17906. * Increase PiP snapping speed ([\element-hq#6539](matrix-org/matrix-react-sdk#6539)). Fixes element-hq#18371. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve and move the incoming call toast ([\element-hq#6470](matrix-org/matrix-react-sdk#6470)). Fixes element-hq#17912. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Allow all of the URL schemes that Firefox allows ([\element-hq#6457](matrix-org/matrix-react-sdk#6457)). Contributed by [aaronraimist](https://github.com/aaronraimist). * Improve bubble layout colors ([\element-hq#6452](matrix-org/matrix-react-sdk#6452)). Fixes element-hq#18081. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Spaces let users switch between Home and All Rooms behaviours ([\element-hq#6497](matrix-org/matrix-react-sdk#6497)). Fixes element-hq#18093. * Support for MSC2285 (hidden read receipts) ([\element-hq#6390](matrix-org/matrix-react-sdk#6390)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Group pinned message events with MELS ([\element-hq#6349](matrix-org/matrix-react-sdk#6349)). Fixes element-hq#17938. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Make version copiable ([\element-hq#6227](matrix-org/matrix-react-sdk#6227)). Fixes element-hq#17603 and element-hq#18329. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve voice messages uploading state ([\element-hq#6530](matrix-org/matrix-react-sdk#6530)). Fixes element-hq#18226 and element-hq#18224. * Add surround with feature ([\element-hq#5510](matrix-org/matrix-react-sdk#5510)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Improve call event tile wording ([\element-hq#6545](matrix-org/matrix-react-sdk#6545)). Fixes element-hq#18376. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Show an avatar/a turned off microphone icon for muted users ([\element-hq#6486](matrix-org/matrix-react-sdk#6486)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Prompt user to leave rooms/subspaces in a space when leaving space ([\element-hq#6424](matrix-org/matrix-react-sdk#6424)). Fixes element-hq#18071. * Add support for screen sharing in 1:1 calls ([\element-hq#5992](matrix-org/matrix-react-sdk#5992)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Dismiss electron download toast when clicking Open ([\element-hq#18267](element-hq#18267)). Fixes element-hq#18266. * [Release] Fix glare related regressions ([\element-hq#6622](matrix-org/matrix-react-sdk#6622)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * [Release] Fix PiP of held calls ([\element-hq#6612](matrix-org/matrix-react-sdk#6612)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * [Release] Fix toast colors ([\element-hq#6607](matrix-org/matrix-react-sdk#6607)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix [object Object] in Widget Permissions ([\element-hq#6560](matrix-org/matrix-react-sdk#6560)). Fixes element-hq#18384. Contributed by [Palid](https://github.com/Palid). * Fix right margin for events on IRC layout ([\element-hq#6542](matrix-org/matrix-react-sdk#6542)). Fixes element-hq#18354. * Mirror only usermedia feeds ([\element-hq#6512](matrix-org/matrix-react-sdk#6512)). Fixes element-hq#5633. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix LogoutDialog warning + TypeScript migration ([\element-hq#6533](matrix-org/matrix-react-sdk#6533)). * Fix the wrong font being used in the room topic field ([\element-hq#6527](matrix-org/matrix-react-sdk#6527)). Fixes element-hq#18339. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix inconsistent styling for links on hover ([\element-hq#6513](matrix-org/matrix-react-sdk#6513)). Contributed by [janogarcia](https://github.com/janogarcia). * Fix incorrect height for encoded placeholder images ([\element-hq#6514](matrix-org/matrix-react-sdk#6514)). Contributed by [Palid](https://github.com/Palid). * Fix call events layout for message bubble ([\element-hq#6465](matrix-org/matrix-react-sdk#6465)). Fixes element-hq#18144. * Improve subspaces and some utilities around room/space creation ([\element-hq#6458](matrix-org/matrix-react-sdk#6458)). Fixes element-hq#18090 element-hq#18091 and element-hq#17256. * Restore pointer cursor for SenderProfile in message bubbles ([\element-hq#6501](matrix-org/matrix-react-sdk#6501)). Fixes element-hq#18249. * Fix issues with the Call View ([\element-hq#6472](matrix-org/matrix-react-sdk#6472)). Fixes element-hq#18221. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Align event list summary read receipts when using message bubbles ([\element-hq#6500](matrix-org/matrix-react-sdk#6500)). Fixes element-hq#18143. * Better positioning for unbubbled events in timeline ([\element-hq#6477](matrix-org/matrix-react-sdk#6477)). Fixes element-hq#18132. * Realign reactions row with messages in modern layout ([\element-hq#6491](matrix-org/matrix-react-sdk#6491)). Fixes element-hq#18118. Contributed by [robintown](https://github.com/robintown). * Fix CreateRoomDialog exploding when making public room outside of a space ([\element-hq#6492](matrix-org/matrix-react-sdk#6492)). Fixes element-hq#18275. * Fix call crashing because `element` was undefined ([\element-hq#6488](matrix-org/matrix-react-sdk#6488)). Fixes element-hq#18270. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Upscale thumbnails to the container size ([\element-hq#6589](matrix-org/matrix-react-sdk#6589)). Fixes element-hq#18307. * Fix create room dialog in spaces no longer adding to the space ([\element-hq#6587](matrix-org/matrix-react-sdk#6587)). Fixes element-hq#18465. * Don't show a modal on call reject/user hangup ([\element-hq#6580](matrix-org/matrix-react-sdk#6580)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fade Call View Buttons after `componentDidMount` ([\element-hq#6581](matrix-org/matrix-react-sdk#6581)). Fixes element-hq#18439. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix missing expand button on codeblocks ([\element-hq#6565](matrix-org/matrix-react-sdk#6565)). Fixes element-hq#18388. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * allow customizing the bubble layout colors ([\element-hq#6568](matrix-org/matrix-react-sdk#6568)). Fixes element-hq#18408. Contributed by [benneti](https://github.com/benneti). * Don't flash "Missed call" when accepting a call ([\element-hq#6567](matrix-org/matrix-react-sdk#6567)). Fixes element-hq#18404. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix clicking whitespaces on replies ([\element-hq#6571](matrix-org/matrix-react-sdk#6571)). Fixes element-hq#18327. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix composer not being disabled when sending voice messages ([\element-hq#6562](matrix-org/matrix-react-sdk#6562)). Fixes element-hq#18413. * Fix sizing issues of the screen picker ([\element-hq#6498](matrix-org/matrix-react-sdk#6498)). Fixes element-hq#18281. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Stop voice messages that are playing when starting a recording ([\element-hq#6563](matrix-org/matrix-react-sdk#6563)). Fixes element-hq#18410. * Fix random box appearing when clicking room list headers. ([\element-hq#6561](matrix-org/matrix-react-sdk#6561)). Fixes element-hq#18414. * Null guard space inviter to prevent the app exploding ([\element-hq#6558](matrix-org/matrix-react-sdk#6558)). * Make the ringing sound mutable/disablable ([\element-hq#6534](matrix-org/matrix-react-sdk#6534)). Fixes element-hq#15591. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix wrong cursor being used in PiP ([\element-hq#6551](matrix-org/matrix-react-sdk#6551)). Fixes element-hq#18383. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Re-pin Jitsi if the widget already exists ([\element-hq#6226](matrix-org/matrix-react-sdk#6226)). Fixes element-hq#17679. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix broken call notification regression ([\element-hq#6526](matrix-org/matrix-react-sdk#6526)). Fixes element-hq#18335. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * createRoom, only send join rule event if we have a join rule to put in it ([\element-hq#6516](matrix-org/matrix-react-sdk#6516)). Fixes element-hq#18301. * Fix clicking pills inside replies ([\element-hq#6508](matrix-org/matrix-react-sdk#6508)). Fixes element-hq#18283. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix grecaptcha regression ([\element-hq#6503](matrix-org/matrix-react-sdk#6503)). Fixes element-hq#18284. Contributed by [Palid](https://github.com/Palid). * Fix compatibility with accounts where the security passphrase was created on a mobile device ([\element-hq#1819](matrix-org/matrix-js-sdk#1819)).

move everything not explicitly riot (or status) branded into matrix-r…

3ecbfae

…eact-sdk

ara4n mentioned this pull request Apr 11, 2018

move everything not explicitly riot (or status) branded into matrix-react-sdk matrix-org/matrix-react-sdk#1836

Merged

4 tasks

ara4n added 10 commits April 12, 2018 20:21

move themes to res to match sdk

e899fec

move notif UTs to sdk

8757c8c

fix braindead typo

41d6995

make VectorHomePage override HomePage

f569fdd

point to new CSS locations

534155f

fix theme paths

be34c84

export enum via method for convenience from matrix-react-sdk

3d20a64

move conference handler to matrix-react-sdk

aefb782

move rageshake to sdk

d693125

copy resources from their new locations

a46b718

ara4n added 7 commits April 15, 2018 23:22

run gen-i18n to refresh translations now most are moved to react-sdk

b8d4866

run prune-i18n to bring translations inline now most are moved to rea…

ce36dec

…ct-sdk

switch karma image loc

0243ec0

merge develop

7c1eafd

kill theming 404s when UTing

8684fae

fix theming during tests correctly

5c34115

fix tests

c8b26a1

ara4n assigned lukebarnard1 Apr 16, 2018

lukebarnard1 suggested changes Apr 17, 2018

View reviewed changes

ara4n added 2 commits April 18, 2018 10:20

convert VectorHomePage into ES6 and have it nicely override HomePage

7ee5343

move deps to sdk for stuff now in the sdk

df3fb83

dbkr reviewed Apr 18, 2018

View reviewed changes

ara4n added 2 commits April 18, 2018 16:20

flesh out status todo comment

e046a72

PR feedback; fix staticness and add ;s

104a415

dbkr approved these changes Apr 18, 2018

View reviewed changes

ara4n merged commit ddc20e2 into develop Apr 18, 2018

t3chguy deleted the matthew/fix_layering branch May 12, 2022 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move everything not explicitly riot (or status) branded into matrix-react-sdk #6500

move everything not explicitly riot (or status) branded into matrix-react-sdk #6500

ara4n commented Apr 11, 2018 •

edited

Loading

martindale commented Apr 13, 2018

ara4n commented Apr 16, 2018

lukebarnard1 left a comment

lukebarnard1 Apr 17, 2018

ara4n Apr 17, 2018

lukebarnard1 Apr 17, 2018

ara4n Apr 17, 2018

dbkr Apr 18, 2018 •

edited

Loading

dbkr Apr 18, 2018

ara4n Apr 18, 2018

dbkr Apr 18, 2018

		@@ -0,0 +1,2 @@
		Any UTs for vector-web layer components or functionality should go here.
		This used to contain the UTs for notifications before they got moved to react-sdk.

move everything not explicitly riot (or status) branded into matrix-react-sdk #6500

move everything not explicitly riot (or status) branded into matrix-react-sdk #6500

Conversation

ara4n commented Apr 11, 2018 • edited Loading

martindale commented Apr 13, 2018

ara4n commented Apr 16, 2018

lukebarnard1 left a comment

Choose a reason for hiding this comment

lukebarnard1 Apr 17, 2018

Choose a reason for hiding this comment

ara4n Apr 17, 2018

Choose a reason for hiding this comment

lukebarnard1 Apr 17, 2018

Choose a reason for hiding this comment

ara4n Apr 17, 2018

Choose a reason for hiding this comment

dbkr Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

dbkr Apr 18, 2018

Choose a reason for hiding this comment

ara4n Apr 18, 2018

Choose a reason for hiding this comment

dbkr Apr 18, 2018

Choose a reason for hiding this comment

ara4n commented Apr 11, 2018 •

edited

Loading

dbkr Apr 18, 2018 •

edited

Loading